fix: inopportune scaling events would lose some status fields #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Suen <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
jessesuen
changed the title
jessesuen
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3060 +/- ##
==========================================
- Coverage 81.75% 81.74% -0.01%
==========================================
Files 134 134
Lines 20395 20407 +12
==========================================
+ Hits 16674 16682 +8
- Misses 2865 2868 +3
- Partials 856 857 +1
☔ View full report in Codecov by Sentry. |
zachaller
approved these changes
Oct 4, 2023
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 13, 2023
…oj#3060) fix: inopportune scaling events would result in loss of data Signed-off-by: Jesse Suen <[email protected]> Signed-off-by: Philip Clark <[email protected]>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…oj#3060) fix: inopportune scaling events would result in loss of data Signed-off-by: Jesse Suen <[email protected]> Signed-off-by: Philip Clark <[email protected]>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…oj#3060) fix: inopportune scaling events would result in loss of data Signed-off-by: Jesse Suen <[email protected]> Signed-off-by: Philip Clark <[email protected]>
zachaller
pushed a commit
that referenced
this pull request
Oct 30, 2023
fix: inopportune scaling events would result in loss of data Signed-off-by: Jesse Suen <[email protected]>
zachaller
pushed a commit
that referenced
this pull request
Oct 30, 2023
fix: inopportune scaling events would result in loss of data Signed-off-by: Jesse Suen <[email protected]>
zachaller
pushed a commit
that referenced
this pull request
Oct 30, 2023
fix: inopportune scaling events would result in loss of data Signed-off-by: Jesse Suen <[email protected]>
zachaller
added
the
cherry-pick-completed
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2931
During a scaling event, we will now only perform scaling against our ReplicaSets, and only reconcile:
status.availableReplicasstatus.HPAReplicasThis fixes a bug where we would lose some information in status (because we did not perform the normal full logic of reconciliation).
Checklist:
"fix(controller): Updates such and such. Fixes #1234".